Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Wrap applications if there are a bunch #4686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

fix: Wrap applications if there are a bunch #4686

merged 1 commit into from
Oct 21, 2022

Conversation

kylecarbs
Copy link
Member

Fixes #4672.

@kylecarbs kylecarbs self-assigned this Oct 21, 2022
@kylecarbs kylecarbs requested a review from a team as a code owner October 21, 2022 17:27
@kylecarbs kylecarbs requested review from code-asher and bpmct and removed request for a team October 21, 2022 17:27
@kylecarbs kylecarbs enabled auto-merge (squash) October 21, 2022 17:51
alignItems="center"
spacing={0.5}
wrap="wrap"
maxWidth="750px"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is maxWidth to prevent the left column from getting squashed? If so I wonder if we could do something like put white-space: nowrap or similar on the left column instead then the right can take up whatever space is left over. For example with the current max-width setting you can still get some wonkiness depending on your screen size:

width

With no-wrap:

nowrap

@kylecarbs kylecarbs merged commit 2c47cda into main Oct 21, 2022
@kylecarbs kylecarbs deleted the appwrap branch October 21, 2022 19:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: coder app links css is borked
2 participants