fix: Allow custom Git OAuth URLs #4758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Oct 26, 2022
| AuthURL string `json:"auth_url"` | ||
| TokenURL string `json:"token_url"` | ||
| Regex string `json:"regex"` | ||
| Scopes []string `json:"scopes"` |
There was a problem hiding this comment.
Should we consider omitempty here? I noticed typegen needs to be run for this PR, which adds the TypeScript entry for scopes, however, if the API doesn't ensure that Scopes: nil becomes, Scopes: []string{}, then we're lying to TypeScript (at which point using omitempty is appropriate).
7d1246e to
dabaf64
Compare
Kira-Pilot
approved these changes
Oct 26, 2022
e0018c0 to
5d9882f
Compare
Fixes an issue reported in Discord where custom endpoints weren't working.
5d9882f to
aeb105a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue reported in Discord where custom endpoints weren't working.