-
Notifications
You must be signed in to change notification settings - Fork 892
chore: windows winget package auto update on every release #4761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added `winget` update action on release
Not sure how to test it. Will it submit the package in my name or the coder |
A GitHub Personal Access token is required to submit packages to winget community repo. https://github.com/microsoft/winget-create/blob/main/doc/token.md Please create a token as shown here and store it as a secret in `GITHUB_PAT`
To push an update, we first need to create a package for the first time that is interactive and manual. |
Also, https://github.com/microsoft/winget-create/blob/main/doc/token.md Please create a token as shown here and store it as a secret in Or maybe the existing |
My PR was closed as a duplicate of microsoft/winget-pkgs#86238, I did not check that you have already submitted a PR. |
I'll do a review pass of this PR on Monday and get it merged for you. We'll sort out the bounty payout post-merge cc @ghuntley |
I updated your PR to use GH CLI instead of pinging the API directly (to avoid potential ratelimits), as well as updated it to comment on the PR pinging me so microsoft maintainers can get in contact with me if something's wrong. I also discovered that the file version I was inserting into the installer binary was incorrect so I fixed that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I contributed so I'll get Colin to review it
Yes, it looks like a better approach. Yes, the installer version had the 4th section as the release date. |
Thanks for sending in the pull-request @matifali I'm going to have a look/review after lunch. A quick note to say haven't forgotten! |
Added
winget
publish action on release.Linked to #3714
@deansheather