Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add count endpoint for users, enabling better pagination #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 8, 2022
Merged

feat: add count endpoint for users, enabling better pagination #4848

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5acfb83
Start on backend
presleyp Oct 31, 2022
9b42678
Hook up frontend
presleyp Oct 31, 2022
97027d2
Add to frontend test
presleyp Nov 1, 2022
486839b
Add go test, wip
presleyp Nov 1, 2022
3a8e4bb
Fix some test bugs
presleyp Nov 1, 2022
f083580
Fix test
presleyp Nov 2, 2022
72d4657
Merge branch 'main' into users-count/presleyp
presleyp Nov 2, 2022
424358e
Format
presleyp Nov 2, 2022
6f8ec23
Add to authorize.go
presleyp Nov 3, 2022
5b442b4
copy user array into local variable
f0ssel Nov 4, 2022
3929a00
Authorize route
presleyp Nov 4, 2022
4f9eb6f
Log count error
presleyp Nov 4, 2022
7d8562c
Authorize better
presleyp Nov 4, 2022
b230df1
Tweaks to authorization
presleyp Nov 4, 2022
ca4a82f
More authorization tweaks
presleyp Nov 4, 2022
998725b
Make gen
presleyp Nov 7, 2022
e40949c
Merge branch 'main' into users-count/presleyp
presleyp Nov 7, 2022
4210e28
Fix test
presleyp Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add to frontend test
  • Loading branch information
@presleyp
presleyp committed Nov 1, 2022
commit 97027d23aebf7ad5cb090c49188ca4fe31709922
10 changes: 8 additions & 2 deletions site/src/pages/UsersPage/UsersPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,27 +240,33 @@ describe("UsersPage", () => {

describe("pagination", () => {
it("goes to next and previous page", async () => {
renderPage()
const { container } = renderPage()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that we have tests and I'm happy to keep these in there. I'm curious if we should just add tests for the pagination widget itself, rather than tests for each time it's implemented.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I added a bit to the widget in a previous PR but I think there's also value in making sure the page is using the widget properly

const user = userEvent.setup()

const mock = jest
.spyOn(API, "getUsers")
.mockResolvedValueOnce([MockUser, MockUser2])

const nextButton = await screen.findByLabelText("Next page")
expect(nextButton).toBeEnabled()
const previousButton = await screen.findByLabelText("Previous page")
expect(previousButton).toBeDisabled()
await user.click(nextButton)

await waitFor(() =>
expect(API.getUsers).toBeCalledWith({ offset: 25, limit: 25, q: "" }),
)

mock.mockClear()
const previousButton = await screen.findByLabelText("Previous page")
await user.click(previousButton)

await waitFor(() =>
expect(API.getUsers).toBeCalledWith({ offset: 0, limit: 25, q: "" }),
)

const pageButtons = await container.querySelectorAll(`button[name="Page button"]`)
// count handler says there are 2 pages of results
expect(pageButtons.length).toBe(2)
})
})

Expand Down