feat(windows): rename windows agent to coder.exe #5052
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghuntley
commented
Nov 14, 2022
| @@ -15,7 +15,7 @@ while ($true) { | |||
| # https://github.com/microsoft/vscode-remote-release/issues/5699 | |||
| $BINARY_URL="${ACCESS_URL}/bin/coder-windows-${ARCH}.exe" | |||
| Write-Output "Fetching coder agent from ${BINARY_URL}" | |||
| Invoke-WebRequest -Uri "${BINARY_URL}" -OutFile $env:TEMP\sshd.exe | |||
| Invoke-WebRequest -Uri "${BINARY_URL}" -OutFile $env:TEMP\coderd.exe | |||
There was a problem hiding this comment.
question: shall we call it coder.exe or coderd.exe?
kylecarbs
reviewed
Nov 14, 2022
|
See: microsoft/vscode-remote-release#5699 It's very sad that we need to call it |
|
Perhaps we could create a hardlink using I'm not sure if Windows could be running on top of a fringe filesystem that results in a hard-linking error, but it could be a "best effort" attempt to have both commands available. |
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smallest possible change to improve #5050