feat(windows): add product information to coder.exe #5055
Conversation
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
8de3a1e to
539ddd1
Compare
539ddd1 to
11ca693
Compare
| dependencies osslsigncode | ||
| requiredenvs AUTHENTICODE_CERTIFICATE_FILE AUTHENTICODE_CERTIFICATE_PASSWORD_FILE | ||
|
|
||
| osslsigncode sign \ |
There was a problem hiding this comment.
Signing of windows executables in the next year is migrating [1] to requiring storage of the certificate to be within a hardware appliance (ie Google Cloud HSM).
[1] https://twitter.com/vcsjones/status/1595236155276120065 and https://knowledge.digicert.com/generalinformation/new-private-key-storage-requirement-for-standard-code-signing-certificates-november-2022.html
| fi | ||
|
|
||
| if [[ "$os" == "windows" ]]; then | ||
| goversioninfo -platform-specific=true \ |
There was a problem hiding this comment.
Currently the following files are outputted in ~
-rw-r--r-- 1 coder coder 193962 Nov 23 05:07 resource_windows_386.syso
-rw-r--r-- 1 coder coder 193962 Nov 23 05:07 resource_windows_amd64.syso
-rw-r--r-- 1 coder coder 193962 Nov 23 05:07 resource_windows_arm.syso
-rw-r--r-- 1 coder coder 193962 Nov 23 05:07 resource_windows_arm64.syso
Need to embed the appropriate arch into the appropriate windows build.
| @@ -119,6 +119,9 @@ jobs: | |||
| AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }} | |||
| AC_APIKEY_ID: ${{ secrets.AC_APIKEY_ID }} | |||
| AC_APIKEY_FILE: /tmp/apple_apikey.p8 | |||
| CODER_SIGN_WINDOWS: "0" | |||
| AUTHENTICODE_CERTIFICATE_FILE: /tmp/windows_cert.pkcs12 | |||
There was a problem hiding this comment.
Code signing certificates can be obtained via https://sectigo.com/ssl-certificates-tls/code-signing and will require organization validation (ie. a DUNS number and corresponding phone number that works)
| @@ -119,6 +119,9 @@ jobs: | |||
| AC_APIKEY_ISSUER_ID: ${{ secrets.AC_APIKEY_ISSUER_ID }} | |||
| AC_APIKEY_ID: ${{ secrets.AC_APIKEY_ID }} | |||
| AC_APIKEY_FILE: /tmp/apple_apikey.p8 | |||
| CODER_SIGN_WINDOWS: "0" | |||
There was a problem hiding this comment.
I've set this at 0 by default under assumption that we will obtain the signing certificate and install it afterwards as part of a seperate pull-request as signing certificates will take a couple of weeks.
|
Please ping me for review on this PR when it's ready and I'll give it a review for you 👍 |
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Progresses #5050
Outstanding
Recommended Reading
Remarks