Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Avoid running shell twice in coder agent #5061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2022
Merged

fix: Avoid running shell twice in coder agent #5061

merged 1 commit into from
Nov 14, 2022

Conversation

mafredri
Copy link
Member

The users login shell would be executed as:

/bin/bash -c '/bin/bash -l'

This simplifies the command for login shells so that the executed
command is:

/bin/bash -l

@mafredri
fix: Avoid running shell twice in coder agent
acda6a9 
The users login shell would be executed as:

	/bin/bash -c '/bin/bash -l'

This simplifies the command for login shells so that the executed
command is:

	/bin/bash -l
@mafredri mafredri self-assigned this Nov 14, 2022
@mafredri mafredri requested a review from a team November 14, 2022 11:02
@mafredri mafredri merged commit e72927f into main Nov 14, 2022
@mafredri mafredri deleted the mafredri/simplify-agent-run-command branch November 14, 2022 12:01
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @deansheather