chore(site): Add unit tests, mocks #514
Conversation
Codecov Report
@@ Coverage Diff @@
## main #514 +/- ##
==========================================
- Coverage 60.35% 60.22% -0.14%
==========================================
Files 191 193 +2
Lines 10864 10875 +11
Branches 85 83 -2
==========================================
- Hits 6557 6549 -8
- Misses 3587 3603 +16
- Partials 720 723 +3
Continue to review full report at Codecov.
|
site/src/Main.tsx
Outdated
| <Router> | ||
| <App /> | ||
| </Router>, |
There was a problem hiding this comment.
Thinking out loud (non-blocking): Something that we lose/was nice in the prior implementation is a single entrypoint into the React application <App>. I think this PR is a step in the right direction and an improvement, so I don't think we need to optimize for this now, but I'd expect to see one component here eventually. I think a related problem is that we don't keep App thin right now, and can probably extract out the providers like in v1.
We can think on this later; I'm getting the thoughts out there, but don't want to block!
There was a problem hiding this comment.
Yeah I think the better way to do what I was trying to do is to split App into two components, one that has the router and providers, and one that has the routes. That way we could test the routes one with a test setup and keep Main simple.
There was a problem hiding this comment.
I just did that, what do you think? let me know if there's a better name!
This addresses part of #485.
utilsso we can reuse them elsewhere if needed.