feat: Add support for MOTD file in coder agents #5147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c07c235 to
59692da
Compare
mafredri
commented
Nov 23, 2022
55ae718 to
5dba999
Compare
mtojek
approved these changes
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for showing MOTD (message of the day) in coder agents when the user logs in via SSH.
It follows closely to the implementation in OpenSSH, a
~/.hushloginfile disables the message, as does non-login sessions (e.g.ssh coder.test echo hi).It relies on coder/terraform-provider-coder#78 which landed in v0.6.4 of the terraform provider.
In the future, this functionality could perhaps be expanded so that e.g. vscode or jetbrains extensions can show motd or motd-like messages as well.