refactor: Remove login banner#5239
Merged
Merged
Conversation
code-asher
approved these changes
Dec 2, 2022
Contributor
Author
|
@code-asher I think it is not. The Coder logo is only at the top of the message 🤔 I took a look at the Storybook to confirm. I'm not sure if I'm understanding it correctly. |
Contributor
Author
|
@code-asher Merging but I can send a PR right after with a fix if that is needed. |
Member
|
Oh yup you are right! I was looking at the Chromatic diff and thought it showed in two places but that was just the diff highlight showing it was gone. 🤦 My bad! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #5232