chore: Improve CI builds by improving caching and decomposing steps #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kylecarbs
commented
Mar 22, 2022
•
- Separates the mock and PostgreSQL database tests.
- Fixes the Go mod cache being separate per-OS.
- Fixes a few race conditions that appeared during testing.
Codecov Report
@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 62.54% 60.40% -2.15%
==========================================
Files 191 191
Lines 10856 10864 +8
Branches 85 85
==========================================
- Hits 6790 6562 -228
- Misses 3341 3583 +242
+ Partials 725 719 -6
Continue to review full report at Codecov.
|
coadler
approved these changes
Mar 22, 2022
| select { | ||
| case <-timer.C: | ||
| p.failActiveJobf("cancelation timed out") | ||
| return | ||
| case <-ctx.Done(): | ||
| timer.Stop() |
There was a problem hiding this comment.
Why do we only want to stop the timer on a context cancel?
There was a problem hiding this comment.
The timer will automatically stop if it completes, since it's not a ticker!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.