fix: stop time incrementer on workspace page #5406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
approved these changes
Dec 14, 2022
|
@BrunoQuaresma yes, but when I went to I realized the max deadline doesn't depend on the template at all anymore since the template has a default rather than a max - reworking it now! |
|
I have tests in mind for this but I'm having some trouble with them, so in the interest of wrapping up PRs before the break I'd like to merge this and come back for the tests in #5476. |
| @@ -19,13 +19,13 @@ export const EditHours = ({ | |||
| const styles = useStyles() | |||
|
|
|||
| return ( | |||
| <form onSubmit={() => handleSubmit(hours)}> | |||
| <form onSubmit={() => handleSubmit(Number.isNaN(hours) ? 0 : hours)}> | |||
There was a problem hiding this comment.
when is it going to be NaN?
There was a problem hiding this comment.
When you delete the number from the input
There was a problem hiding this comment.
Maybe we could add a comment explaining this? So we know why we are checking it. Up to you.
BrunoQuaresma
approved these changes
Dec 20, 2022
There was a problem hiding this comment.
@presleyp that sounds fair enough. I just had a minor question.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5354
The incrementer wasn't working when the template default ttl was 0, because the max deadline was being calculated as start time + 0.