Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add create template from the UI #5427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 61 commits into from
Dec 21, 2022
Merged

feat: Add create template from the UI #5427

merged 61 commits into from
Dec 21, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Dec 20, 2022
@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review December 20, 2022 18:26
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner December 20, 2022 18:26
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team December 20, 2022 18:26
@presleyp
Copy link
Contributor

presleyp commented Dec 20, 2022

Doing some QA:
👍🏻

  • the starter template and create template pages look nice!
  • creating from an AWS starter template failed, but I think that's expected. It showed logs, and Retry and Cancel worked.
  • creating from a Docker starter template succeeded
  • both pages correctly show a validation error if I leave out the name
  • emoji picker works
  • filters on starter templates page work
  • file uploader works

To check out:

  • if I focus the Schedule input and then scroll the page, the number changes. That might be a feature of a number input but it surprised me.
  • The display name and description inputs don't allow spaces
  • I tried to create a template without a file and saw "Error" under the template name field - I'm guessing it was in response to the lack of a file but it wasn't informative and looked like it was complaining about the name (which was filled in)

@presleyp
Copy link
Contributor

I still had an error while provisioning my own template (probably user error) but the issues I found are fixed!

@BrunoQuaresma BrunoQuaresma merged commit c505e8b into main Dec 21, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/fe-examples branch December 21, 2022 21:07
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants