-
Notifications
You must be signed in to change notification settings - Fork 886
feat: Add systemd service and production deployment #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #545 +/- ##
==========================================
- Coverage 62.69% 62.38% -0.31%
==========================================
Files 194 108 -86
Lines 10837 9904 -933
Branches 85 0 -85
==========================================
- Hits 6794 6179 -615
+ Misses 3302 3016 -286
+ Partials 741 709 -32
Continue to review full report at Codecov.
|
b99eb50
to
c5530cb
Compare
This modifies CI to use a dpkg produced from release to update and run Coder on a tiny VM in GCP. It's intentionally kept simple, because customers should be able to get this same easy install experience.
cli/start.go
Outdated
if os.Getenv("DUMP") != "" { | ||
root.Flags().VisitAll(func(flag *pflag.Flag) { | ||
fmt.Printf("%s %s\n", flag.Name, flag.Usage) | ||
}) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems interesting, is it just a way to debug all of the cobra flags? If it's something we want to keep maybe we can give it a more descriptive env name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was debug code for some testing stuff. I'm happy you caught it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the e2e simplification!!!!! 🎉
This modifies CI to use a dpkg produced from release to update and
run Coder on a tiny VM in GCP.
It's intentionally kept simple, because customers should
be able to get this same easy install experience.