test: Update go-scp to fix data race #5469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to upstream: bramvdbogaerde/go-scp#66
go.mod
Outdated
| // This package is only used in tests, but there's a data race causing | ||
| // occasional flakes. | ||
| // https://github.com/bramvdbogaerde/go-scp/pull/66 | ||
| replace github.com/bramvdbogaerde/go-scp => github.com/mafredri/go-scp v1.2.1-0.20221123115109-607fd1f5015c |
There was a problem hiding this comment.
This should be forked to coder instead of mafredrei. Even with no special permissions members of coder can fork/create repos in it.
There was a problem hiding this comment.
If there's a pull upstream, I don't care if it's on the dev's personal. I just don't want maintained forks on personal ;p.
There was a problem hiding this comment.
I considered it but don't think it's worth it here since this is a lib only used in tests. Once the change is upstreamed I'll get rid of the repo, if we fork it we'll be stuck on our fork forever. 😅
kylecarbs
approved these changes
Dec 19, 2022
mtojek
reviewed
Dec 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to upstream: bramvdbogaerde/go-scp#66
This flakes every now and a then, tried to upstream but no response yet.
https://github.com/coder/coder/actions/runs/3733778064/jobs/6335003283