Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add GPG forwarding to coder ssh #5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 6, 2023
Merged

feat: add GPG forwarding to coder ssh #5482

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b7bc639
feat: add GPG forwarding to coder ssh
deansheather Dec 20, 2022
c270898
fixup! feat: add GPG forwarding to coder ssh
deansheather Dec 20, 2022
6c10fa4
feat: unix forwarding in agent SSH server
deansheather Jan 4, 2023
9ebf840
chore: working agent forwarding tests (tcp and unix)
deansheather Jan 4, 2023
d85dc66
feat: working GPG agent forwarding test
deansheather Jan 4, 2023
e203bf0
fixup! feat: working GPG agent forwarding test
deansheather Jan 4, 2023
a90d3d6
chore: PR comments
deansheather Jan 5, 2023
e07d204
fixup! chore: PR comments
deansheather Jan 5, 2023
216c028
fixup! chore: PR comments
deansheather Jan 5, 2023
a0f70de
chore: fix tests on darwin for SSH unix forwarding
deansheather Jan 5, 2023
17c7f99
fixup! chore: fix tests on darwin for SSH unix forwarding
deansheather Jan 5, 2023
ed5ff26
Merge branch 'main' into dean/gpg-forward
deansheather Jan 5, 2023
130ddfd
fixup! Merge branch 'main' into dean/gpg-forward
deansheather Jan 5, 2023
9c6cfba
chore: PR comments
deansheather Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! chore: fix tests on darwin for SSH unix forwarding
  • Loading branch information
@deansheather
deansheather committed Jan 5, 2023
commit 17c7f9958523e65dbf53c392901f3e9f5babf9e4
2 changes: 1 addition & 1 deletion cli/ssh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ func ssh() *cobra.Command {
cliflag.BoolVarP(cmd.Flags(), &shuffle, "shuffle", "", "CODER_SSH_SHUFFLE", false, "Specifies whether to choose a random workspace")
_ = cmd.Flags().MarkHidden("shuffle")
cliflag.BoolVarP(cmd.Flags(), &forwardAgent, "forward-agent", "A", "CODER_SSH_FORWARD_AGENT", false, "Specifies whether to forward the SSH agent specified in $SSH_AUTH_SOCK")
cliflag.BoolVarP(cmd.Flags(), &forwardGPG, "forward-gpg", "G", "CODER_SSH_FORWARD_GPG", false, "Specifies whether to forward the GPG agent. Unsupported on Windows workspaces, but supports all clients. Requires gnupg (gpg, gpgconf) on both the client and workspace. The GPG agent must already be running locally and will not be started for you. If a GPG agent is already running in the workspace, it will be attempted to be killed. It is recommended that you set GPG_TTY, TTY or SSH_TTY to $(tty) beforehand.")
cliflag.BoolVarP(cmd.Flags(), &forwardGPG, "forward-gpg", "G", "CODER_SSH_FORWARD_GPG", false, "Specifies whether to forward the GPG agent. Unsupported on Windows workspaces, but supports all clients. Requires gnupg (gpg, gpgconf) on both the client and workspace. The GPG agent must already be running locally and will not be started for you. If a GPG agent is already running in the workspace, it will be attempted to be killed.")
cliflag.StringVarP(cmd.Flags(), &identityAgent, "identity-agent", "", "CODER_SSH_IDENTITY_AGENT", "", "Specifies which identity agent to use (overrides $SSH_AUTH_SOCK), forward agent must also be enabled")
cliflag.DurationVarP(cmd.Flags(), &wsPollInterval, "workspace-poll-interval", "", "CODER_WORKSPACE_POLL_INTERVAL", workspacePollInterval, "Specifies how often to poll for workspace automated shutdown.")
return cmd
Expand Down