refactor: move footer items into the user dropdown #5562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The items at the bottom looked unprofessional. Users don't always need to be prompted to join our Discord or see the active version of Coder. This moves the items in the user dropdown which looks better.
code-asher
reviewed
Jan 3, 2023
|
|
||
| <Divider /> | ||
|
|
||
| <Tooltip title="Browse Source Code"> |
There was a problem hiding this comment.
Just curious why a Tooltip over the native title prop on the anchor? So it pops up faster maybe?
There was a problem hiding this comment.
The title property wasn't appearing for me for some reason...
There was a problem hiding this comment.
Ahh gotcha, there was a title="View Source" on the Discord link so it might have been on the wrong one!
site/src/components/UserDropdownContent/UserDropdownContent.tsx
Outdated
Show resolved
Hide resolved
| import { FC } from "react" | ||
| import { Link } from "react-router-dom" | ||
| import * as TypesGen from "../../api/typesGenerated" | ||
| import { navHeight } from "../../theme/constants" | ||
| import { DocsIcon } from "../Icons/DocsIcon" | ||
| import { LogoutIcon } from "../Icons/LogoutIcon" | ||
| import { UserAvatar } from "../UserAvatar/UserAvatar" | ||
| import Tooltip from "@material-ui/core/Tooltip" |
There was a problem hiding this comment.
Does v2 have sorting preferences for frontend imports? We might need a linting rule to help automate it.
|
FYI: I'm going to push a few improvements later today but feel free to merge it. I can do the improvement on the main. |
BrunoQuaresma
approved these changes
Jan 4, 2023
code-asher
approved these changes
Jan 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The items at the bottom looked unprofessional. Users don't always need to be prompted to join our Discord or see the active version of Coder.
This moves the items in the user dropdown which looks better.
Related #5465
Before:
After:
