Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Switch from npm to yarn in scripts/apidocgen #5575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jan 4, 2023

It seems sensible to use yarn in both site and scripts/apidocgen.

Some errors have been seen with make gen which prompted this PR, like:

npm WARN prepare removing existing node_modules/ before installation

> [email protected] postinstall /home/coder/coder/scripts/apidocgen/node_modules/core-js
> node -e "try{require('./postinstall')}catch(e){}"

added 200 packages in 1.848s

Usage: npm <command>

where <command> is one of:
    access, adduser, audit, bin, bugs, c, cache, ci, cit,
    clean-install, clean-install-test, completion, config,
    create, ddp, dedupe, deprecate, dist-tag, docs, doctor,
    edit, explore, fund, get, help, help-search, hook, i, init,
    install, install-ci-test, install-test, it, link, list, ln,
    login, logout, ls, org, outdated, owner, pack, ping, prefix,
    profile, prune, publish, rb, rebuild, repo, restart, root,
    run, run-script, s, se, search, set, shrinkwrap, star,
    stars, start, stop, t, team, test, token, tst, un,
    uninstall, unpublish, unstar, up, update, v, version, view,
    whoami

npm <command> -h  quick help on <command>
npm -l            display full usage info
npm help <term>   search for help on <term>
npm help npm      involved overview

Specify configs in the ini-formatted file:
    /home/coder/.npmrc
or on the command line via: npm <command> --key value
Config info can be viewed via: npm help config

[email protected] /usr/lib/node_modules/npm

make: *** [Makefile:487: coderd/apidoc/swagger.json] Error 1
make: *** Deleting file 'coderd/apidoc/swagger.json'

This may or may not fix the above issue.

@mafredri mafredri self-assigned this Jan 4, 2023
@mtojek mtojek self-requested a review January 4, 2023 18:38
@mtojek mtojek marked this pull request as ready for review January 4, 2023 18:38
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works on my end, so let's get this in! Thanks for being proactive.

@mtojek mtojek merged commit ebe1b56 into main Jan 4, 2023
@mtojek mtojek deleted the mafredri/apidocgen-npm-to-yarn branch January 4, 2023 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants