Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Added --with-terraform argument to install coder and terraform together #5586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 6, 2023
Merged

feat: Added --with-terraform argument to install coder and terraform together #5586

merged 7 commits into from
Jan 6, 2023

Conversation

nanospearing
Copy link
Contributor

  • Added a --install-terraform argument
  • Added a unzip command check to the standalone function
  • Cleaner error and help redirect the user to a solution
  • Added help info for --with-terraform argument
  • Fixed standalone install typo (ard64 -> arm64)

I have read the CLA Document and I hereby sign the CLA

Admin added 3 commits January 5, 2023 00:32
- Added a --install-terraform argument
82d49db 
- Added a unzip command check to the standalone function
	- Cleaner error and help redirect the user to a solution
- Added help info for `--install-terraform` argument
- Fixed standalone install typo (ard64 -> arm64)
Merge branch 'main' of https://github.com/coder/coder
d11feae
- Corrected formatting errors, and renamed functions
d514c18
@github-actions
Copy link

github-actions bot commented Jan 5, 2023 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nanospearing
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@nanospearing
Copy link
Contributor Author

recheck

kylecarbs
kylecarbs reviewed Jan 5, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, overall awesome contribution!

p.s. thanks for fixing the ard64 -> arm64 🙈

@nanospearing
Copy link
Contributor Author

Oh cool, it shows typos! I will get those fixed as well.

Admin added 2 commits January 5, 2023 01:44
- Fixed typos
cfd33f9 
- Added recommend changes for consistency
Removed unzip check in standalone function
2869757
@kylecarbs
Copy link
Member

@KozmikNano could you run fmt and fix the shellcheck?

@nanospearing
Copy link
Contributor Author

@KozmikNano could you run fmt and fix the shellcheck?

Yes! Sorry for the late reply.

@nanospearing
Copy link
Contributor Author

@kylecarbs Should be good now.

@nanospearing
Copy link
Contributor Author

Thank you for your continued patience!

@kylecarbs
Copy link
Member

@KozmikNano thank you for the contribution! Much appreciated.

@nanospearing
Copy link
Contributor Author

@KozmikNano thank you for the contribution! Much appreciated.

Anytime, glad I could help!

@nanospearing nanospearing requested a review from kylecarbs January 5, 2023 23:18
@matifali
Copy link
Member

matifali commented Jan 6, 2023

Did you also update the related docs and main readme? @KozmikNano

@nanospearing
Copy link
Contributor Author

Did you also update the related docs and main readme? @KozmikNano

I didn't see anything in the docs that referenced the command list, however I did add information to help argument in install.sh.

@kylecarbs kylecarbs merged commit 9b602f5 into coder:main Jan 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@nanospearing nanospearing

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nanospearing @kylecarbs @matifali