chore: update Lima example #5588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johnstcn
commented
Jan 5, 2023
- Updates Ubuntu base image used by Lima example
- Makes Docker socket usable by Lima user without sudo inside VM
- Updates access URL of Coder deployment to host.lima.internal
mafredri
approved these changes
Jan 5, 2023
There was a problem hiding this comment.
It's unfortunate we have to open up the docker socket globally, but I couldn't figure out a much better way either.
I guess we could do chown lima on it and have the chmod be chmod og+rwx. It would be slightly more restricted and docker group would work as previously.
| @@ -81,6 +87,8 @@ provision: | |||
| usermod -aG docker coder | |||
| # Ensure coder listens on all interfaces | |||
| sed -i 's/CODER_ADDRESS=.*/CODER_ADDRESS=0.0.0.0:3000/' /etc/coder.d/coder.env | |||
| # Also set the access URL to host.lima.internal for fast deployments | |||
| sed -i 's#CODER_ACCESS_URL=.*#CODER_ACCESS_URL=http://host.lima.internal:3000#' /etc/coder.d/coder.env | |||
There was a problem hiding this comment.
Does this make the other change unnecessary? The one where we do:
sed -i 's/host.lima.internal.*/host.lima.internal host.docker.internal/' /etc/hosts
There was a problem hiding this comment.
Does this make the other change unnecessary? The one where we do:
sed -i 's/host.lima.internal.*/host.lima.internal host.docker.internal/' /etc/hosts
I'm not sure, but I'd prefer to keep the alias for host.docker.internal around regardless.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.