refactor: Do not display port forward button if it is disabled #5604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BrunoQuaresma can you add a screenshot of the new deployment UI? |
jsjoeio
approved these changes
Jan 6, 2023
|
@kylecarbs yeap! I forgot that |
|
@kylecarbs I decided just to add a section in the Network Settings page since there are a few ways to setup port forward. What do you think? I would keep it simple as it is and maybe, improve it if we notice users missing it or giving us directly feedback. Thoughts?
|
jsjoeio
approved these changes
Jan 9, 2023
| @@ -39,6 +39,9 @@ export default { | |||
| }, | |||
| }, | |||
| }, | |||
| wildcard_access_url: { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4283