Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: User settings page #5661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 10, 2023
Merged

refactor: User settings page #5661

merged 4 commits into from
Jan 10, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Update the user settings page to use the same layout as Deployment Settings.

Things to consider:

  • The components are not abstracted yet. I would wait a bit before creating common components. I'm not sure this is the design we want to keep/follow.

Before:
Screen Shot 2023-01-10 at 16 13 29
Screen Shot 2023-01-10 at 16 13 37
Screen Shot 2023-01-10 at 16 13 45

After:
Screen Shot 2023-01-10 at 16 13 56
Screen Shot 2023-01-10 at 16 14 16
Screen Shot 2023-01-10 at 16 14 05

@BrunoQuaresma BrunoQuaresma self-assigned this Jan 10, 2023
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner January 10, 2023 19:21
@BrunoQuaresma BrunoQuaresma requested review from presleyp and removed request for a team January 10, 2023 19:21
kylecarbs
kylecarbs approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this!

@BrunoQuaresma BrunoQuaresma merged commit f5d623f into main Jan 10, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-user-settings-page branch January 10, 2023 20:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@presleyp presleyp Awaiting requested review from presleyp presleyp was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @kylecarbs