feat: Separate workspace agent for tests #567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #567 +/- ##
==========================================
+ Coverage 62.92% 63.07% +0.15%
==========================================
Files 194 195 +1
Lines 11097 11205 +108
Branches 85 85
==========================================
+ Hits 6983 7068 +85
- Misses 3358 3373 +15
- Partials 756 764 +8
Continue to review full report at Codecov.
|
coadler
approved these changes
Mar 25, 2022
agent/conn.go
Outdated
| Protocol: "ssh", | ||
| }) | ||
| if err != nil { | ||
| return nil, err |
Contributor
There was a problem hiding this comment.
Missing lots of wraps in this file
Member
Author
There was a problem hiding this comment.
Good call. Dunno why I do that 🤦
This adds tests for Google Cloud authentication, and lays the ground-work for future agent auth types in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for Google Cloud authentication, and lays
the ground-work for future agent auth types in the future.