refactor: Extract ssh logic from auth service #5670
Conversation
Co-authored-by: Kira Pilot <[email protected]>
| confirmLoading={authState.matches( | ||
| "signedIn.ssh.loaded.regeneratingSSHKey", | ||
| )} | ||
| open={sshState.matches("confirmSSHKeyRegenerate")} |
There was a problem hiding this comment.
Sometimes we're making variables for sshState keys and sometimes we aren't - can we choose one and be consistent?
There was a problem hiding this comment.
The matches function only return true or false. Unfortunately, xstate v4 does not have a way to bind a context type with a specific state so, sometimes, we have to check the state with match and pass the value in the context. Buuut, after these minor refactoring, I think we can remove some xstate machines and use just use fetch directly.
| }), | ||
| notifySuccessSSHKeyRegenerated: () => { | ||
| displaySuccess(Language.successRegenerateSSHKey) | ||
| }, |
| }, | ||
| }, | ||
| notLoaded: { | ||
| type: "final", |
There was a problem hiding this comment.
Thinking about our conversation about simplifying XState machines by having less granularity: instead of making a separate error, getSSHKeyError, can we instead look at sshState.matches("notLoaded")?
There was a problem hiding this comment.
In this case we store this because we want to display the error.
There was a problem hiding this comment.
Oh, I didn't see the separate loading state - makes sense!
SSH can be a separated machine since it is not related to the authentication at all.