ci: Allow missing commit metadata to be ignored in releases #5678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jan 11, 2023
scripts/release.sh
Outdated
Comment on lines
40
to
43
| # Temporary workaround for commits on `main` without a PR, we can remove this | ||
| # once we ensure all commits for a release will have a PR. | ||
| # Also see .github/workflow/release.yml. | ||
| export CODER_IGNORE_MISSING_COMMIT_METADATA=1 |
There was a problem hiding this comment.
We probably don't need this since we can just set it manually ourselves, less to remember to manually undo later on.
There was a problem hiding this comment.
Hmm.. good idea! Then I'll just turn this into an action input 🤔. Then we can default to require metadata.
deansheather
approved these changes
Jan 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release script is currently failing, this fixes that: