Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: Fix release workflow input booleans, remove snapshot #5688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 12, 2023

Conversation

mafredri
Copy link
Member

No description provided.

@mafredri mafredri force-pushed the mafredri/ci-fix-release-workflow-env-vars branch from dc3afae to 88a30af Compare January 12, 2023 11:57
@mafredri mafredri force-pushed the mafredri/ci-fix-release-workflow-env-vars branch from eff3735 to 182fc6d Compare January 12, 2023 12:23
@mafredri mafredri force-pushed the mafredri/ci-fix-release-workflow-env-vars branch from 9cfd9f7 to 23f723c Compare January 12, 2023 12:25
@mafredri mafredri force-pushed the mafredri/ci-fix-release-workflow-env-vars branch from 4de46cd to 8c3297d Compare January 12, 2023 12:30
@mafredri mafredri force-pushed the mafredri/ci-fix-release-workflow-env-vars branch from 9435bd0 to 1e63d4c Compare January 12, 2023 12:36
@mafredri mafredri changed the title ci: Fix release workflow env vars ci: Fix release workflow inputs to be actual booleans Jan 12, 2023
@mafredri
Copy link
Member Author

With the change from github.event.inputs to inputs, and booleans being actual booleans. We could re-introduce the (partially correct) behavior from before:

${{ inputs.dry_run && '--dry-run' || '' }}

Note the added || '' which is required to avoid outputting false.

@mafredri mafredri changed the title ci: Fix release workflow inputs to be actual booleans ci: Fix release workflow input booleans, remove snapshot Jan 12, 2023
@mafredri mafredri force-pushed the mafredri/ci-fix-release-workflow-env-vars branch 2 times, most recently from 29d120a to 3ccc538 Compare January 12, 2023 13:39
@mafredri mafredri force-pushed the mafredri/ci-fix-release-workflow-env-vars branch from 3ccc538 to 77ca70a Compare January 12, 2023 14:55
@mafredri mafredri marked this pull request as ready for review January 12, 2023 15:05
@mafredri
Copy link
Member Author

Booleans should now work, and snapshot has been removed to simplify slightly.

In the future. Let's rewrite this so that one workflow produces release notes and creates and pushes the tag. And that in turn triggers this workflow to produce the actual release.

@mafredri mafredri force-pushed the mafredri/ci-fix-release-workflow-env-vars branch from dd25b99 to 3d44c27 Compare January 12, 2023 15:20
@mafredri mafredri enabled auto-merge (squash) January 12, 2023 15:50
@mafredri mafredri merged commit a5073a8 into main Jan 12, 2023
@mafredri mafredri deleted the mafredri/ci-fix-release-workflow-env-vars branch January 12, 2023 15:51
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants