Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: Wrap forms into dashboard layout #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 12, 2023
Merged

refactor: Wrap forms into dashboard layout #5697

merged 2 commits into from
Jan 12, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Jan 12, 2023 •
edited
Loading

This helps us to wrap all the dashboard pages into a single layout reducing the number of times we had to wrap routes with <NavbarLayout>

Before:
Screen Shot 2023-01-12 at 16 40 55

After:
Screen Shot 2023-01-12 at 16 40 45

@BrunoQuaresma BrunoQuaresma self-assigned this Jan 12, 2023
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner January 12, 2023 19:43
@BrunoQuaresma BrunoQuaresma requested review from jsjoeio and removed request for a team January 12, 2023 19:43
@BrunoQuaresma BrunoQuaresma merged commit 3861d1c into main Jan 12, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-form-layouts branch January 12, 2023 20:08
@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@jsjoeio jsjoeio Awaiting requested review from jsjoeio jsjoeio was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @kylecarbs