Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: turn e2e tests back on with fixes #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 17, 2023
Merged

chore: turn e2e tests back on with fixes #5719

merged 7 commits into from
Jan 17, 2023

Conversation

presleyp
Copy link
Contributor

Removed unnecessary lines, made workspace name always unique, extended timeouts, turned e2e back on.

@presleyp presleyp requested a review from a team as a code owner January 13, 2023 21:56
@presleyp presleyp requested review from jsjoeio and removed request for a team January 13, 2023 21:56
@presleyp
Copy link
Contributor Author

I ran the e2e tests 10 times in CI with no failures so hopefully this resolved the flakiness!

jsjoeio
jsjoeio approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes!

@presleyp presleyp merged commit 63956ea into main Jan 17, 2023
@presleyp presleyp deleted the e2e-timeout branch January 17, 2023 17:12
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@presleyp @jsjoeio