test: Fix flaky TestServer/Logging/{Multiple,Stackdriver} #5727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Jan 16, 2023
kylecarbs
approved these changes
Jan 16, 2023
johnstcn
approved these changes
Jan 17, 2023
|
Ran into temp dir cleanup errors on Windows, at first I tried to fix the wrong issue. Turned out it was a test bug creating and opening files without closing them. So I introduced two new |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this flaking on dogfood instance due to Terraform being downloaded and adding a good amount of time (15+ seconds) to startup.
In lieu of disabling terraform download, this should help alleviate such pains.