Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: deduplicate / type license feature code #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 17, 2023
Merged

refactor: deduplicate / type license feature code #5734

merged 13 commits into from
Jan 17, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Jan 16, 2023

No description provided.

@ammario ammario marked this pull request as ready for review January 17, 2023 01:01
@ammario ammario requested a review from a team as a code owner January 17, 2023 01:01
@ammario ammario requested review from Kira-Pilot and kylecarbs and removed request for a team January 17, 2023 01:01
"start",
"stop",
"write",
]
Copy link
Member

@Kira-Pilot Kira-Pilot Jan 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised to see these array types generated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was introduced in this PR so the FE didn't have to maintain a manual list of available enterprise features.

Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE ✅

@ammario ammario merged commit 501cfa9 into main Jan 17, 2023
@ammario ammario deleted the licenses branch January 17, 2023 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants