feat: remove server subcommand from slim binaries #5747
Conversation
buildinfo/buildinfo.go
Outdated
| @@ -73,6 +75,16 @@ func IsDev() bool { | |||
| return strings.HasPrefix(Version(), develPrefix) | |||
| } | |||
|
|
|||
| // IsSlim returns true if this is a slim build. | |||
| func IsSlim() bool { | |||
| return strings.Contains(slim, "t") | |||
There was a problem hiding this comment.
Could we set this via build tag so that it's present when doing go build as well? (I.e. we don't need to inject it via ldflags.)
There was a problem hiding this comment.
Like by using go build -tags slim?
There was a problem hiding this comment.
Sure, but we won't be able to detect agpl this way since we don't use a flag for it.
There was a problem hiding this comment.
Done for slim, AGPL still uses ldflags. I've added a comment to build_go.sh why we don't provide an agpl build flag
| "github.com/spf13/viper" | ||
|
|
||
| "github.com/coder/coder/cli/deployment" | ||
| "github.com/coder/coder/coderd" |
There was a problem hiding this comment.
Importing coderd here is unfortunate. I think we could reduce binary size if we didn't but I might be wrong. I think we can avoid it if we change enterprise slim too?
There was a problem hiding this comment.
Sadly also root.go uses this function so the signature needs to match on both. I think this could be done as a second improvement, but I want to get this in so we can unblock the community PR #5738
There was a problem hiding this comment.
Ah, didn't think of that. Yes makes sense 👍🏻.
slimtag if this is a slim buildIsSlim()andIsAGPL()tobuildinfo, and add those details tocoder versionserver_slim.go(in both AGPL and enterprise CLI) which only builds withslimtagserveHandlerfromserver.gotoagent.goThis doesn't fully remove the server code from slim binaries, as the packages are still imported, but it disables them.