Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Setup redirect state #5759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2023
Merged

fix: Setup redirect state #5759

merged 3 commits into from
Jan 18, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

After setup a new user we have to refresh a few pieces of info like permissions, entitlements, etc. We could refetch this info and update the state but it adds a complexity we don't need to have, at least for this screen since it will be used only once. So I just decided to do a "hard" redirect which is simple and does not add any logic complexity.

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner January 17, 2023 19:27
@BrunoQuaresma BrunoQuaresma self-assigned this Jan 17, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team January 17, 2023 19:27
@BrunoQuaresma
Copy link
Collaborator Author

Fix #5568

}
}, [authState, navigate])
}, [authState])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) January 18, 2023 15:27
@BrunoQuaresma BrunoQuaresma merged commit 6252f78 into main Jan 18, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-trial-redirect-setup branch January 18, 2023 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants