feat(examples): add labels and antiAffinity to k8s example #5763
Conversation
| "app.kubernetes.io/name" = "coder-workspace" | ||
| "app.kubernetes.io/instance" = "coder-workspace-${lower(data.coder_workspace.me.owner)}-${lower(data.coder_workspace.me.name)}" | ||
| "app.kubernetes.io/part-of" = "coder" |
There was a problem hiding this comment.
Should add some more labels similar to what we do in v1 for workspace details. Should add these to the PVC too.
There was a problem hiding this comment.
Added the labels I could from v1
$ kdpo coder-colin-gea
Name: coder-colin-gea
Namespace: colin-coder
Priority: 0
Service Account: default
Node: gke-dev-4-2-coder-node-pool-8b0aaa9c-wfg6/10.1.0.102
Start Time: Wed, 18 Jan 2023 10:49:01 -0600
Labels: app.kubernetes.io/instance=coder-workspace-colin-gea
app.kubernetes.io/name=coder-workspace
app.kubernetes.io/part-of=coder
com.coder.resource=true
com.coder.user=b851db54-9827-45bc-b453-72138b46f99c
com.coder.username=colin
com.coder.workspace.id=8118ca50-2edc-4b7c-8b70-61b3c7c3673d
com.coder.workspace.name=gea$ kd pvc coder-colin-gea-home
Name: coder-colin-gea-home
Namespace: colin-coder
StorageClass: standard
Status: Bound
Volume: pvc-d6612185-b553-459a-9c85-acce9bf33cc2
Labels: app.kubernetes.io/instance=coder-pvc-colin-gea
app.kubernetes.io/name=coder-pvc
app.kubernetes.io/part-of=coder
com.coder.resource=true
com.coder.workspace.id=8118ca50-2edc-4b7c-8b70-61b3c7c3673d
com.coder.workspace.name=gea| affinity { | ||
| pod_anti_affinity { | ||
| preferred_during_scheduling_ignored_during_execution { | ||
| weight = 1 | ||
| pod_affinity_term { | ||
| topology_key = "kubernetes.io/hostname" | ||
| label_selector { | ||
| match_expressions { | ||
| key = "app.kubernetes.io/name" | ||
| operator = "In" | ||
| values = ["coder-workspace"] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm confused, because wouldn't this fail for the defaults on most Kubernetes cluster that don't have the hostname of coder-workspace?
There was a problem hiding this comment.
It's matching pods that have app.kubernetes.io/name: coder-workspace, summing the amount partitioned by hostname. Our helm chart has something similar
There was a problem hiding this comment.
Ahh, I see. So even if you didn't deploy Coder with Kubernetes, this would still work? We should add a comment here.
There was a problem hiding this comment.
This is part of the spec, so I imagine any k8s-like apis would also implement this. I found some references to it in the openshift docs: https://docs.openshift.com/container-platform/4.8/nodes/scheduling/nodes-scheduler-node-selectors.html#nodes-scheduler-node-selectors-about_nodes-scheduler-node-selectors
There was a problem hiding this comment.
Oh I think I understand your question. This doesn't have anything to do with how Coder itself is deployed.
| "com.coder.workspace.id" = data.coder_workspace.me.id | ||
| "com.coder.workspace.name" = data.coder_workspace.me.name | ||
| "com.coder.user.id" = data.coder_workspace.me.owner_id | ||
| "com.coder.user.username" = data.coder_workspace.me.owner |
There was a problem hiding this comment.
email too, we provide email as owner_email
No description provided.