Set all existing agents to ready

coder · mafredri · Jan 24, 2023 · Jan 19, 2023 · Jan 19, 2023 · Jan 19, 2023
commit 830f9f1439f6abb04a34928e20be3193c29947d0
diff --git a/coderd/database/dump.sql b/coderd/database/dump.sql
diff --git a/coderd/database/migrations/000091_add_workspace_agent_state.up.sql b/coderd/database/migrations/000091_add_workspace_agent_state.up.sql
@@ -1,13 +1,19 @@
 CREATE TYPE workspace_agent_lifecycle_state AS ENUM ('created', 'starting', 'start_timeout', 'start_error', 'ready');
 
-ALTER TABLE workspace_agents ADD COLUMN lifecycle_state workspace_agent_lifecycle_state NOT NULL DEFAULT 'created';
-COMMENT ON COLUMN workspace_agents.lifecycle_state IS 'The current lifecycle state of the workspace agent.';
+-- Set all existing workspace agents to 'ready' so that only newly created agents will be in the 'created' state.
+ALTER TABLE workspace_agents ADD COLUMN lifecycle_state workspace_agent_lifecycle_state NOT NULL DEFAULT 'ready';
+-- Change the default for newly created agents.
+ALTER TABLE workspace_agents ALTER COLUMN lifecycle_state SET DEFAULT 'created';
 
-/* Set default values that conform to current behavior */
-/* Allow logins immediately after agent connect */
+COMMENT ON COLUMN workspace_agents.lifecycle_state IS 'The current lifecycle state reported by the workspace agent.';
+
+-- Set default values that conform to current behavior.
+-- Allow logins immediately after agent connect.
 ALTER TABLE workspace_agents ADD COLUMN delay_login_until_ready boolean NOT NULL DEFAULT false;
+
 COMMENT ON COLUMN workspace_agents.delay_login_until_ready IS 'If true, the agent will delay logins until it is ready (e.g. executing startup script has ended).';
 
-/* Disable startup script timeouts by default */
+-- Disable startup script timeouts by default.
 ALTER TABLE workspace_agents ADD COLUMN startup_script_timeout_seconds int4 NOT NULL DEFAULT 0;
+
 COMMENT ON COLUMN workspace_agents.startup_script_timeout_seconds IS 'The number of seconds to wait for the startup script to complete. If the script does not complete within this time, the agent lifecycle will be marked as start_timeout.';
diff --git a/coderd/database/models.go b/coderd/database/models.go