chore: Update sqlc to v1.16.0 #5788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
reviewed
Jan 19, 2023
ae9aa46 to
cc002a1
Compare
|
I noticed invalid inserts in telemetry test (i.e. things that would never work in real postgres), so I went ahead and implemented validation in See We'll now have some form of validation on inserts in the fake as well. Unfortunately it requires some manual plumbing when creating fake methods: This doesn't fix all issues, though, fixing the issues reported by |
mafredri
commented
Jan 20, 2023
Comment on lines
+505
to
+509
| // Ignore log errors because we get: | ||
| // | ||
| // (*Server).FailJob audit log - get build {"error": "sql: no rows in result set"} | ||
| ignoreLogErrors := true | ||
| srv := setup(t, ignoreLogErrors) |
There was a problem hiding this comment.
I invite extra scrutiny to this test here! The audit log implementation may not have ideal behavior. Please ensure that we actually shouldn't audit log when a workspace build wasn't created.
Emyrk
reviewed
Jan 20, 2023
Comment on lines
163
to
171
| // Note: database.Null* types don't have a Valid method, we skip them here | ||
| // because their embedded types may have a Valid method and we don't want | ||
| // to bother with checking both that tha Valid field is true and that the | ||
| // type it embeds validates to true. We would need to check: | ||
| // | ||
| // dbNullEnum.Valid && dbNullEnum.Enum.Valid() | ||
| if strings.HasPrefix(v.Type().Name(), "Null") { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
The above comment on the function says we do not go into nested structs. Isn't the Nullable case a nested struct?
There was a problem hiding this comment.
So this is to do nothing in the following scenario:
validateDatabaseType(database.NullThing{}) // HasPrefix NullIf we have:
validateDatabaseType(database.MyType{Thing: database.NullThing{}})We ultimately will not validate Thing since we only go one level deep and the validator function doesn't check structs.
This was just to keep the logic (simpler) and not having to look at both database.NullThing.Valid == true && database.NullThing.Thing.Valid().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use enum validation in #5749 and saw sqlc had added it, so I updated.
On the road, I noticed we've had nullable values that we didn't really treat that way. So I did a migration to change them:
I considered adding
DEFAULT 'none', but I thought that would be more likely to hide issues. Does this seem like the right solution to that?Also note the
UserStatuschange, we were not treating it as nullable before, although the database schema allowed it.