Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: filter workspace_build resource on start/stop action #5809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

Kira-Pilot
Copy link
Member

resolves #4796

Screen Shot 2023-01-20 at 9 54 53 AM
Screen Shot 2023-01-20 at 9 55 05 AM

@Kira-Pilot Kira-Pilot requested review from Emyrk and coadler January 20, 2023 15:26
@Kira-Pilot Kira-Pilot changed the title fix: ufilter workspace_build resource on start/stop action fix: filter workspace_build resource on start/stop action Jan 20, 2023
@Kira-Pilot Kira-Pilot requested a review from a team as a code owner January 20, 2023 15:31
@Kira-Pilot Kira-Pilot requested review from BrunoQuaresma and removed request for a team January 20, 2023 15:31
@@ -35,9 +35,11 @@ const presetFilters = [
name: "Created workspaces",
},
{ query: "resource_type:template action:create", name: "Added templates" },
{ query: "resource_type:user action:create", name: "Added users" },
{ query: "resource_type:template action:delete", name: "Deleted templates" },
{ query: "resource_type:user action:delete", name: "Deleted users" },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were fairly redundant so I've removed them.

Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both, FE and BE look good to me

@Kira-Pilot Kira-Pilot merged commit 0e58772 into main Jan 20, 2023
@Kira-Pilot Kira-Pilot deleted the filter-workspace-build/kira-pilot branch January 20, 2023 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit: allow filtering by workspace build start/stop
3 participants