feat: Adjust forms to include Rich Parameters #5856
Conversation
| size="small" | ||
| disabled={disabled} | ||
| placeholder={parameter.default_value} | ||
| value={parameterValue} |
There was a problem hiding this comment.
This error usually happens when the value changes from string to undefined. Many times, having undefined values is a "bug" warning but in a few cases, it is ok so what you have to do is pass an empty string as a fallback:
value={parameterValue ?? ""}
There was a problem hiding this comment.
I introduced the parameterValue as I wasn't able to fix it with formik. It looks like formik has troubles with understanding the concept of array of object, and for some reason, the input goes undefined. I will look into this.
There was a problem hiding this comment.
I see, so maybe the getFormHelpers has a bug 🤔
|
Hey @BrunoQuaresma! I'm done with the implementation, but I need to increase test coverage for Update workspace. I will do this tomorrow, but I appreciate any comments on the code in the mean time. This should be reviewable. PS. I apologize for the PR size... |
BrunoQuaresma
left a comment
There was a problem hiding this comment.
FE code looks very good to me, congrats! I'm going to run a QA before approving it.
BrunoQuaresma
left a comment
There was a problem hiding this comment.
I mean, if you already did that and you are confident, feel free to merge it!
Related: #5574
Changes:
http://localhost:3000/templates/docker-2/workspace?param.Compute%20instances=7