Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add iron bank Dockerfile & manifest #5934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 7, 2023
Merged

feat: add iron bank Dockerfile & manifest #5934

merged 13 commits into from
Feb 7, 2023

Conversation

ericpaulsen
Copy link
Member

adds Iron Bank-compatible Dockerfile & hardening manifest. this will be the master copy that we will copy into the Iron Bank repo.

@ericpaulsen ericpaulsen added enhancement enterprise Enterprise-license / premium functionality labels Jan 31, 2023
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want this to be a top-level folder. Let's put it inside of scripts.

@deansheather
Copy link
Member

scripts doesn't seem appropriate as there are no scripts, but we don't have a deploy folder like v1....

@kylecarbs
Copy link
Member

@deansheather I don't think there's a point in creating a new folder type for this because it's so bespoke.

@ericpaulsen
Copy link
Member Author

prettier is returning the following error:

site/src/components/AuthProvider/AuthProvider.tsx[error] site/src/components/AuthProvider/AuthProvider.tsx: SyntaxError: '>' expected. (23:18)
[error]   21 |
[error]   22 | type UseAuthReturnType = ReturnType<
[error] > 23 |   typeof useActor<AuthContextValue["authService"]>
[error]      |                  ^
[error]   24 | >
[error]   25 |
[error]   26 | export const useAuth = (): UseAuthReturnType => {

@deansheather let me know the best path forward to resolve.

@deansheather
Copy link
Member

@ericpaulsen I'd try checking out main, pulling, then checkout the PR branch again and do git merge main to update the branch since it's not a file you touched

@deansheather
Copy link
Member

We should merge this even with all of the vulnerabilities reported by trivy, and focus on fixing them after merge. Some of them are vulnerabilities in the base image which we might not be able to resolve.

@ericpaulsen ericpaulsen dismissed kylecarbs’s stale review February 7, 2023 22:59

the requested changes were made.

@ericpaulsen ericpaulsen merged commit f24547e into main Feb 7, 2023
@ericpaulsen ericpaulsen deleted the iron-bank branch February 7, 2023 23:09
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enterprise Enterprise-license / premium functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants