Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(agent): Work around lumberjack reopening log file after close #5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix(agent): Work around lumberjack reopening log file after close #5941

merged 1 commit into from
Feb 1, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Feb 1, 2023

This is a jank solution around lumberjack re-opening the log file on write, which can happen after close.

@mafredri mafredri requested a review from kylecarbs February 1, 2023 11:02
@mafredri mafredri marked this pull request as ready for review February 1, 2023 11:02
@mafredri mafredri self-assigned this Feb 1, 2023
kylecarbs
kylecarbs approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decent workaround

@mafredri mafredri merged commit 52ace4b into main Feb 1, 2023
@mafredri mafredri deleted the mafredri/fix-lumberjack-open-after-close branch February 1, 2023 14:04
@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @kylecarbs