Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add ability to deploy extra k8s yamls with helm chart #5942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2023
Merged

feat: add ability to deploy extra k8s yamls with helm chart #5942

merged 3 commits into from
Feb 3, 2023

Conversation

mh013370
Copy link
Contributor

@mh013370 mh013370 commented Feb 1, 2023

This PR adds the ability to deploy extra k8s yamls alongside a Coder deployment in k8s. This is useful for creating secrets/configmaps that get mounted into the Coder pod(s).

Tested by running it through helm template:

command > helm template app helm/ --dry-run --debug --set coder.image.tag=test

...
---
# Source: coder/templates/extra-deploy.yaml
apiVersion: v1
data:
  key: value
kind: ConfigMap
metadata:
  name: my-configmap
...

@mh013370 mh013370 changed the title add ability to deploy extra k8s yamls with helm chart feat: add ability to deploy extra k8s yamls with helm chart Feb 1, 2023
@mh013370
Copy link
Contributor Author

mh013370 commented Feb 1, 2023

Since i'm adding new optional configuration, i don't believe the failures are due to my changes in this PR.

@deansheather deansheather self-requested a review February 3, 2023 08:13
deansheather
deansheather reviewed Feb 3, 2023
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll test this out locally in a moment and approve the PR.

@deansheather deansheather enabled auto-merge (squash) February 3, 2023 17:18
@deansheather deansheather merged commit 2285a5e into coder:main Feb 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
@mh013370 mh013370 deleted the add-extra-deploy branch February 4, 2023 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mh013370 @deansheather