chore: change build audit log string to be clearer #6093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
commented
Feb 7, 2023
| @@ -7,9 +7,13 @@ import { | |||
| MockAuditLogUnsuccessfulLoginUnknownUser, | |||
| } from "testHelpers/entities" | |||
| import { AuditLogDescription } from "./AuditLogDescription" | |||
| import { AuditLogRow } from "./AuditLogRow" | |||
| import { render } from "../../testHelpers/renderHelpers" | |||
| import { AuditLogRow } from "../AuditLogRow" | |||
There was a problem hiding this comment.
These tests aren't perfect - I was having difficulty testing strings with an embedded Link. I will return at a later time and maybe turn these into stories or create a custom matcher.
Kira-Pilot
commented
Feb 7, 2023
| version "2.10.0" | ||
| resolved "https://registry.yarnpkg.com/canvas/-/canvas-2.10.0.tgz#5f48c8d1ff86c96356809097020336c3a1ccce27" | ||
| integrity sha512-A0RPxLcH0pPKAY2VN243LdCNcOJXAT8n7nJnN7TZMGv9OuF8we9wfpWgVT/eFMzi+cDYf/384w4BpfjGCD9aKQ== | ||
| canvas@^2.11.0: |
There was a problem hiding this comment.
We're getting changes here because I ran into this issue and had to re-add canvas.
Kira-Pilot
commented
Feb 7, 2023
| @@ -45,6 +45,7 @@ | |||
| "@xstate/inspect": "0.6.5", | |||
| "@xstate/react": "3.0.1", | |||
| "axios": "0.26.1", | |||
| "canvas": "^2.11.0", | |||
There was a problem hiding this comment.
We're getting changes here because I ran into this issue and had to re-add canvas.
BrunoQuaresma
approved these changes
Feb 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a general Audit Log cleanup, focusing on our descriptions:
Before
After
(link is the same - takes you to the log page for that build)