Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: update template examples and docs to install code-server under /tmp #6138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 9, 2023

This PR updates the example templates to install code-server under /tmp using the standalone method, which should require no root privileges.

We found that the default Kubernetes template in OpenShift would fail to install code-server due to lack of sudo access.

@johnstcn johnstcn self-assigned this Feb 9, 2023
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two (potential) issues with storing in /tmp:

  1. It might be mounted tmpfs in which case it'll use up RAM
  2. Could be mounted noexec which is a somewhat common security measure

Edit: Only meant this as a "to keep in mind", don't see it as a real blocker.

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

Co-authored-by: Mathias Fredriksson <[email protected]>
@johnstcn johnstcn merged commit ab9cba9 into main Feb 10, 2023
@johnstcn johnstcn deleted the cj/docs-install-code-server-tmp branch February 10, 2023 13:36
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants