Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: require client pipe to be closed in provisionerd test #6188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: require client pipe to be closed in provisionerd test #6188

merged 1 commit into from
Feb 14, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs requested a review from mafredri February 13, 2023 15:47
@kylecarbs kylecarbs self-assigned this Feb 13, 2023
@kylecarbs kylecarbs enabled auto-merge (squash) February 13, 2023 15:48
mafredri
mafredri approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks like what I was trying to fix/surface in #6182!

@kylecarbs
Copy link
Member Author

@mafredri once race leads to another ;p

@kylecarbs kylecarbs merged commit 2d0a69b into main Feb 14, 2023
@kylecarbs kylecarbs deleted the provisionerrace branch February 14, 2023 00:46
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @mafredri