Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Improve closure of provisioner and agent tailnet dial #6199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 14, 2023
Merged

fix: Improve closure of provisioner and agent tailnet dial #6199

merged 7 commits into from
Feb 14, 2023

Conversation

mafredri
Copy link
Member

These came up when trying to dig into #6198 and the following:

goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 10 in state chan receive, with storj.io/drpc/drpcserver.(*Server).Serve.func1 on top of the stack:
goroutine 10 [chan receive]:
storj.io/drpc/drpcserver.(*Server).Serve.func1({0xc3eea0?, 0xc0004641b0?})
	/home/mafredri/.local/go/pkg/mod/storj.io/[email protected]/drpcserver/server.go:80 +0x45
storj.io/drpc/drpcctx.(*Tracker).track(0xc0004641b0, 0x0?)
	/home/mafredri/.local/go/pkg/mod/storj.io/[email protected]/drpcctx/transport.go:52 +0x2b
created by storj.io/drpc/drpcctx.(*Tracker).Run
	/home/mafredri/.local/go/pkg/mod/storj.io/[email protected]/drpcctx/transport.go:47 +0x8d

 Goroutine 9 in state chan receive, with github.com/valyala/fasthttp/fasthttputil.(*InmemoryListener).Accept on top of the stack:
goroutine 9 [chan receive]:
github.com/valyala/fasthttp/fasthttputil.(*InmemoryListener).Accept(0xc0004641b0?)
	/home/mafredri/.local/go/pkg/mod/github.com/valyala/[email protected]/fasthttputil/inmemory_listener.go:50 +0x35
storj.io/drpc/drpcserver.(*Server).Serve(0xc0004aa000, {0xc3e810, 0xc00015a000}, {0xc3d230?, 0xc000122000})
	/home/mafredri/.local/go/pkg/mod/storj.io/[email protected]/drpcserver/server.go:85 +0x1bb
github.com/coder/coder/provisionerd_test.createProvisionerDaemonClient.func3()
	/home/mafredri/src/coder/coder/provisionerd/provisionerd_test.go:1096 +0x6c
created by github.com/coder/coder/provisionerd_test.createProvisionerDaemonClient
	/home/mafredri/src/coder/coder/provisionerd/provisionerd_test.go:1094 +0x485
]

@mafredri mafredri force-pushed the mafredri/fix-provisioner-closures branch from 03c9788 to 64f6496 Compare February 14, 2023 14:01
@mafredri mafredri force-pushed the mafredri/fix-provisioner-closures branch from 1dfbb39 to f5a53db Compare February 14, 2023 14:18
Base automatically changed from mafredri/fix-websocket-net-conn-contexts to main February 14, 2023 14:42
@mafredri mafredri marked this pull request as ready for review February 14, 2023 14:43
@mafredri mafredri enabled auto-merge (squash) February 14, 2023 14:55
@mafredri mafredri merged commit 41ae01d into main Feb 14, 2023
@mafredri mafredri deleted the mafredri/fix-provisioner-closures branch February 14, 2023 14:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @kylecarbs