Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coder): actually ignore email verified if CODER_OIDC_IGNORE_EMAIL_VERIFIED is set #6236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix(coder): actually ignore email verified if CODER_OIDC_IGNORE_EMAIL_VERIFIED is set #6236

merged 1 commit into from
Feb 16, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Feb 16, 2023 •
edited
Loading

This needs to be wired up to actually do anything.

@johnstcn johnstcn self-assigned this Feb 16, 2023
@johnstcn johnstcn requested review from mafredri and Emyrk and removed request for mafredri February 16, 2023 14:33
@johnstcn johnstcn changed the title fix(coder): actually ignore email verified if config value is set fix(coder): actually ignore email verified if CODER_OIDC_IGNORE_EMAIL_VERIFIED is set Feb 16, 2023
mtojek
mtojek approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp

@johnstcn johnstcn merged commit 81c29c0 into main Feb 16, 2023
@johnstcn johnstcn deleted the cj/actually-ignore-email-verified branch February 16, 2023 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@johnstcn johnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnstcn @mtojek