Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: change dev tunnel default back to true #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

f0ssel
Copy link
Contributor

@f0ssel f0ssel commented Mar 28, 2022

Changing it originally was an accident

@f0ssel f0ssel requested review from kylecarbs and coadler March 28, 2022 22:08
@f0ssel f0ssel enabled auto-merge (squash) March 28, 2022 22:08
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #630 (2ed17b8) into main (e0172dd) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   63.83%   63.60%   -0.23%     
==========================================
  Files         197      111      -86     
  Lines       11537    10464    -1073     
  Branches       85        0      -85     
==========================================
- Hits         7365     6656     -709     
+ Misses       3397     3060     -337     
+ Partials      775      748      -27     
Flag Coverage Δ
unittest-go- 62.97% <100.00%> (+0.14%) ⬆️
unittest-go-macos-latest 58.44% <100.00%> (-0.03%) ⬇️
unittest-go-ubuntu-latest 61.36% <100.00%> (-0.24%) ⬇️
unittest-go-windows-2022 ?
unittest-js ?
Impacted Files Coverage Δ
cli/start.go 64.17% <100.00%> (ø)
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
pty/ptytest/ptytest.go 94.82% <0.00%> (-5.18%) ⬇️
cli/projectinit.go 56.36% <0.00%> (-3.64%) ⬇️
peerbroker/listen.go 83.89% <0.00%> (-3.39%) ⬇️
peer/conn.go 76.14% <0.00%> (-3.30%) ⬇️
coderd/parameter/compute.go 74.07% <0.00%> (-2.23%) ⬇️
provisionerd/provisionerd.go 79.88% <0.00%> (-1.18%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
site/src/components/Icons/WorkspacesIcon.tsx
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0172dd...2ed17b8. Read the comment docs.

@f0ssel f0ssel merged commit 620c889 into main Mar 28, 2022
@f0ssel f0ssel deleted the f0ssel/fix-dev-tunnel-default branch March 28, 2022 22:16
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants