Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: don't log disconnect error when the database is shutting down #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2023
Merged

fix: don't log disconnect error when the database is shutting down #6309

merged 2 commits into from
Feb 22, 2023

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs requested a review from mafredri February 22, 2023 19:51
@kylecarbs kylecarbs self-assigned this Feb 22, 2023
@kylecarbs
Copy link
Member Author

@mafredri I'm not sure if this is the proper fix, but digging a bit online it seems this is what other people have done...

mafredri
mafredri approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that small suggestion, this looks good 👍

@kylecarbs kylecarbs merged commit 2a8a147 into main Feb 22, 2023
@kylecarbs kylecarbs deleted the closerace branch February 22, 2023 22:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @mafredri