Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: update templates to use rich parameters #6397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 36 commits into from
Mar 15, 2023
Merged

chore: update templates to use rich parameters #6397

merged 36 commits into from
Mar 15, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Mar 1, 2023 •
edited by mtojek
Loading

After completion, this will resolve #6073
Contributes to #6075

  • do-linux
  • docker-image-builds
  • docker-with-dotfiles
  • docker-code-server
  • docker
  • gcp-linux
  • gcp-vm-container
  • gcp-windows
  • kubernetes
  • kubernetes-with-podman
  • aws-ecs-container
  • aws-linux
  • aws-windows
  • azure-linux

The checked are tested, and others are to be tested.

@matifali matifali changed the title update templates to use rich parameters chore: update templates to use rich parameters Mar 1, 2023
bpmct
bpmct reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add checkboxes for each template we need to manually test? I can help with the cloud ones :)

@matifali
Copy link
Member Author

matifali commented Mar 9, 2023 •
edited
Loading

Can you add checkboxes for each template we need to manually test? I can help with the cloud ones :)

Done. Also, I removed all instances of terraform variable. May I keep some items as managed variables?

@mtojek mtojek mentioned this pull request Mar 13, 2023
Closed
@matifali matifali requested a review from bpmct March 13, 2023 15:08
@matifali matifali marked this pull request as ready for review March 14, 2023 05:38
@matifali
Copy link
Member Author

Hi @mtojek You may review the changes and provide your feedback. Feel free to directly push if you want to.

@mtojek mtojek self-requested a review March 14, 2023 10:08
mtojek
mtojek reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good progress, @matifali! I left a few comments to address, but I think that this PR is in a really good shape.

mtojek
mtojek reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I started testing templates and I will post spotted bugs.

@matifali matifali requested review from mtojek and removed request for mtojek March 14, 2023 17:08
@matifali matifali requested a review from mtojek March 15, 2023 11:40
mtojek
mtojek reviewed Mar 15, 2023
View reviewed changes
@mtojek
Copy link
Member

mtojek commented Mar 15, 2023

@matifali Could we extract this change to a different pull-request? I wouldn't pack too much into this one, and I'd like to approve it.

@mtojek mtojek self-requested a review March 15, 2023 13:05
@matifali
Copy link
Member Author

Yes, I agree. I have reverted. This is also not related to the current context.

mtojek
mtojek approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Templates were tested, and we fixed a couple of issues. I think that this PR is ready for merging 👍

Well done, @matifali, I appreciate your work on this. Let's keep an eye on template bug reports.

@mtojek mtojek enabled auto-merge (squash) March 15, 2023 13:08
@matifali
Copy link
Member Author

Thanks a lot, @mtojek for testing the templates and pointing out issues that I have missed.
Does the azure-vm template work? I mean there was confusion about region names.

@mtojek mtojek merged commit a0e096b into coder:main Mar 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
@mtojek
Copy link
Member

mtojek commented Mar 15, 2023

Does the azure-vm template work? I mean there was confusion about region names.

Let me check some of those which changed.

@mtojek
Copy link
Member

mtojek commented Mar 15, 2023

Yup, no issues. I checked: Qatar Central, Switzerland North, and UAE North

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs left review comments

@bpmct bpmct bpmct left review comments

@mtojek mtojek mtojek approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rich parameters: convert Coder examples
4 participants
@matifali @mtojek @bpmct @kylecarbs