Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(provisionerd): log workspace build transition in lower case #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Mar 6, 2023

Some services (such as DataDog) will automagically transform log fields to lower case from upper case, but then will perform case-sensitive matching on those log fields.

@johnstcn johnstcn requested a review from a team March 6, 2023 10:52
@johnstcn johnstcn self-assigned this Mar 6, 2023
@johnstcn johnstcn requested review from Kira-Pilot and removed request for a team March 6, 2023 10:52
@johnstcn johnstcn changed the title fix(provisionerd): emit workspace build transition in lower case fix(provisionerd): log workspace build transition in lower case Mar 6, 2023
@johnstcn johnstcn removed the request for review from Kira-Pilot March 6, 2023 11:00
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johnstcn johnstcn merged commit 1483b42 into main Mar 6, 2023
@johnstcn johnstcn deleted the cj/provisionerd-log-workspace-transition-lower branch March 6, 2023 11:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants