Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: adjust workspace filter query when the path changes #6539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions site/src/components/SearchBarWithFilter/SearchBarWithFilter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { makeStyles } from "@material-ui/core/styles"
import { Theme } from "@material-ui/core/styles/createTheme"
import SearchIcon from "@material-ui/icons/Search"
import debounce from "just-debounce-it"
import { useCallback, useRef, useState } from "react"
import { useCallback, useEffect, useRef, useState } from "react"
import { getValidationErrorMessage } from "../../api/errors"
import { CloseDropdown, OpenDropdown } from "../DropdownArrows/DropdownArrows"
import { Stack } from "../Stack/Stack"
Expand All @@ -35,7 +35,10 @@ export const SearchBarWithFilter: React.FC<
> = ({ filter, onFilter, presetFilters, error, docs }) => {
const styles = useStyles({ error: Boolean(error) })
const searchInputRef = useRef<HTMLInputElement>(null)

const [value, setValue] = useState(filter)
useEffect(() => {
setValue(filter)
}, [filter])
// debounce query string entry by user
// we want the dependency array empty here
// as we don't need to redefine the function
Expand Down Expand Up @@ -92,10 +95,11 @@ export const SearchBarWithFilter: React.FC<
<OutlinedInput
id="query"
name="query"
defaultValue={filter}
error={Boolean(error)}
value={value}
className={styles.inputStyles}
onChange={(event) => {
setValue(event.currentTarget.value)
debouncedOnFilter(event.currentTarget.value)
}}
inputRef={searchInputRef}
Expand Down